Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use specified output when using ConanFile.run() with bash #11306

Closed
wants to merge 1 commit into from

Conversation

taoyouh
Copy link

@taoyouh taoyouh commented May 19, 2022

Fix #5670, #11076

Changelog: Feature: Use output provided by user when calling self.run() with win_bash=True
Docs: conan-io/docs#2543

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@memsharded
Copy link
Member

Sorry this PR was not managed back then, it seems that the incomplete CI didn't help.
Conan 2.0 has changed all that code, so this PR would be outdated, so I am closing it. Thanks very much for your contribution anyway!

@memsharded memsharded closed this May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

output is not saved when using self.run() with win_bash=True
3 participants