Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/cmakedeps tool no build type #13267

Merged
merged 5 commits into from Mar 1, 2023
Merged

Fix/cmakedeps tool no build type #13267

merged 5 commits into from Mar 1, 2023

Conversation

memsharded
Copy link
Member

@memsharded memsharded commented Feb 28, 2023 •
edited by czoido

Changelog: Bugfix: CMakeDeps generate files for tool_requires with the same build_type as the "host" context.
Docs: Omit

Close #13209

@memsharded memsharded added this to the 2.0.1 milestone Feb 28, 2023
@memsharded memsharded marked this pull request as ready for review February 28, 2023 23:14
czoido
czoido reviewed Mar 1, 2023
View reviewed changes
conans/__init__.py Outdated Show resolved Hide resolved
@memsharded @czoido
Update conans/__init__.py
4ae896d 
Co-authored-by: Carlos Zoido <mrgalleta@gmail.com>
@czoido czoido merged commit e558f0c into conan-io:develop2 Mar 1, 2023
@memsharded memsharded deleted the fix/cmakedeps_tool_no_build_type branch March 1, 2023 15:25
@memsharded memsharded mentioned this pull request Mar 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcar87 jcar87 jcar87 approved these changes

@czoido czoido czoido approved these changes

@RubenRBS RubenRBS Awaiting requested review from RubenRBS

Assignees

@czoido czoido

Labels
None yet
Projects
None yet
Milestone
2.0.1
Development

Successfully merging this pull request may close these issues.

[bug] CMakeDeps.generate() fails when build_context_activated is used
3 participants
@memsharded @jcar87 @czoido