Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport of <host_version> to 1.X #13719

Merged

Conversation

memsharded
Copy link
Member

@memsharded memsharded commented Apr 19, 2023

Changelog: Feature: Define new version expression tool_requires("pkg/<host_version>") to get the host requirement version (Backport of 2.0 #13712).
Docs: conan-io/docs#3197

Backport of #13712

@memsharded memsharded added this to the 1.60 milestone Apr 19, 2023
@memsharded memsharded requested a review from czoido April 19, 2023 10:48
@SSE4
Copy link
Contributor

SSE4 commented Apr 20, 2023

why add new feature to 1.x?

@memsharded
Copy link
Member Author

why add new feature to 1.x?

Because it is a backport, not a new feature.

@SSE4
Copy link
Contributor

SSE4 commented Apr 24, 2023

Because it is a backport, not a new feature.

IMO it's kinda orthogonal - you can backport bugfix, and you can backport a new feature.
in this particular case you backport a new syntax which didn't exist in 1.x. why is it necessary for old version?
I think it was previously stated multiple times 1.x will not gain new things, only bug fixes.

@memsharded memsharded marked this pull request as ready for review May 4, 2023 11:15
@memsharded memsharded merged commit f3c0372 into conan-io:develop May 4, 2023
2 checks passed
@memsharded memsharded deleted the feature/develop_host_version branch May 4, 2023 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants