Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace 'quiet' cmake loglevel with 'error' #14289

Merged
merged 1 commit into from Jul 13, 2023
Merged

Replace 'quiet' cmake loglevel with 'error' #14289

merged 1 commit into from Jul 13, 2023

Conversation

BobIsOnFire
Copy link
Contributor

@BobIsOnFire BobIsOnFire commented Jul 13, 2023 •
edited by czoido

Changelog: Bugfix: Fix CMake Error: Invalid level specified for --loglevel when tools.build:verbosity is set to quiet.
Docs: omit

I believe this was partially missed from #13729.

@CLAassistant
Copy link

CLAassistant commented Jul 13, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

@BobIsOnFire
Replace 'quiet' cmake loglevel with 'error'
042d1a1 
There is no 'quiet' loglevel in CMake.
@BobIsOnFire BobIsOnFire force-pushed the bugfix/cmake-unknown-loglevel branch from 4baa5f2 to 042d1a1 Compare July 13, 2023 11:40
@memsharded memsharded added this to the 2.0.9 milestone Jul 13, 2023
RubenRBS
RubenRBS approved these changes Jul 13, 2023
View reviewed changes
Copy link
Member

@RubenRBS RubenRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦 No idea how I missed this one, sorry!

Thanks a lot for your bugfix, we really appreciate it :)

@RubenRBS RubenRBS merged commit 382688b into conan-io:release/2.0 Jul 13, 2023
2 checks passed
@BobIsOnFire
Copy link
Contributor Author

Thank you! I guess I was just a little late for getting this into 2.0.8 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RubenRBS RubenRBS RubenRBS approved these changes

Assignees

@RubenRBS RubenRBS

Labels
stage: triaging
Projects
None yet
Milestone
2.0.9
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@BobIsOnFire @CLAassistant @RubenRBS @memsharded