Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: Add support for Alpine Linux #14382

Merged
merged 1 commit into from Jul 30, 2023

Conversation

mkmkme
Copy link
Contributor

@mkmkme mkmkme commented Jul 27, 2023

This commit closes #14307.

Changelog: Feature: Added support for apk package manager and Alpine Linux
Docs: conan-io/docs#3312

  • Refer to the issue that supports this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop2 branch, documenting this one.

Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good, thanks very much for contributing it @mkmkme

I guess that you have also tested it manually with some recipes that uses Apk to install real packages? Even if it cannot be tested in CI, it would be good to make sure that it is working in real reacipes.

@memsharded memsharded added this to the 2.0.10 milestone Jul 28, 2023
@memsharded memsharded self-assigned this Jul 29, 2023
@mkmkme
Copy link
Contributor Author

mkmkme commented Jul 30, 2023

@memsharded thanks for the approval!

Yes, for the test I took opengl package from conan-center-install and added apk to the recipe. Here's the relevant output:

======== Computing necessary packages ========
opengl/system: Forced build from source
Requirements
    opengl/system#c07ee941b5fdaa8277055c3d1a5ca79b:da39a3ee5e6b4b0d3255bfef95601890afd80709 - Build
opengl/system: RUN: apk info -e mesa-gl

opengl/system: RUN: apk update
fetch https://dl-cdn.alpinelinux.org/alpine/v3.18/main/x86_64/APKINDEX.tar.gz
fetch https://dl-cdn.alpinelinux.org/alpine/v3.18/community/x86_64/APKINDEX.tar.gz
v3.18.2-540-g37f67005e76 [https://dl-cdn.alpinelinux.org/alpine/v3.18/main]
v3.18.2-546-g1a7d2d7bbea [https://dl-cdn.alpinelinux.org/alpine/v3.18/community]
OK: 20070 distinct packages available

opengl/system: RUN: apk add --no-cache mesa-gl
fetch https://dl-cdn.alpinelinux.org/alpine/v3.18/main/x86_64/APKINDEX.tar.gz
fetch https://dl-cdn.alpinelinux.org/alpine/v3.18/community/x86_64/APKINDEX.tar.gz
(1/16) Installing mesa (23.0.4-r0)
(2/16) Installing libxau (1.0.11-r2)
(3/16) Installing libmd (1.0.4-r2)
(4/16) Installing libbsd (0.11.7-r1)
(5/16) Installing libxdmcp (1.1.4-r2)
(6/16) Installing libxcb (1.15-r1)
(7/16) Installing libx11 (1.8.4-r4)
(8/16) Installing libxext (1.3.5-r2)
(9/16) Installing libxfixes (6.0.1-r2)
(10/16) Installing libxxf86vm (1.1.5-r3)
(11/16) Installing hwdata-pci (0.370-r0)
(12/16) Installing libpciaccess (0.17-r2)
(13/16) Installing libdrm (2.4.115-r4)
(14/16) Installing mesa-glapi (23.0.4-r0)
(15/16) Installing libxshmfence (1.3.2-r2)
(16/16) Installing mesa-gl (23.0.4-r0)
OK: 84 MiB in 57 packages

The recipe later fails, but the reason for that is that I don't know the corresponding package in Alpine Linux 😊

@memsharded memsharded merged commit aca81fc into conan-io:release/2.0 Jul 30, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] Support Alpine Linux system package manager
2 participants