Fix graph explain not showing some differences in requirements if missing
#15355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RubenRBS
commented
Dec 28, 2023
memsharded
approved these changes
Jan 4, 2024
conan/api/subapi/list.py
Outdated
Comment on lines
277
to
281
| for r in expected_build_requires: | ||
| existing = binary_build_requires.get(r.name) | ||
| if not existing or r != existing: | ||
| self.build_requires_diff.setdefault("expected", set()).add(repr(r)) | ||
| self.build_requires_diff.setdefault("existing", set()).add(repr(existing)) |
There was a problem hiding this comment.
This pattern is repeated a few times, maybe we want to make a local function for it?
RubenRBS
commented
Jan 10, 2024
czoido
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Fix: Fix
graph explainnot showing some differences in requirements if missing.Docs: Omit
Message when the right pkgid is not looked up still pending to add.
This still need to be rebased on top of #15353 for the tests to have a chance to pass, as it was while fixing this that we found the linked PR
This to discuss:
build-requiresnorsettings_target, a contribution for that would be welcome