Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix compile_definitions with no value #15545

Merged
merged 2 commits into from Jan 29, 2024
Merged

fix compile_definitions with no value #15545

merged 2 commits into from Jan 29, 2024

Conversation

memsharded
Copy link
Member

@memsharded memsharded commented Jan 28, 2024 •
edited by czoido

Changelog: Fix: Allow None values for CMakeToolchain.preprocessor_definitions that will map to definitions without values.
Docs: conan-io/docs#3551

Close #8284

@memsharded memsharded mentioned this pull request Jan 28, 2024
Closed
@memsharded memsharded added this to the 2.1 milestone Jan 29, 2024
@memsharded memsharded marked this pull request as ready for review January 29, 2024 10:03
@czoido czoido merged commit daf42dd into conan-io:develop2 Jan 29, 2024
2 checks passed
@memsharded memsharded deleted the fix/compile_definitions_none branch January 29, 2024 16:03
@czoido czoido mentioned this pull request Jan 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franramirez688 franramirez688 franramirez688 approved these changes

@czoido czoido czoido approved these changes

@RubenRBS RubenRBS RubenRBS approved these changes

Assignees

@czoido czoido

Labels
None yet
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.

[bug] Issues with configuration-specific preprocesor definitions in CMakeToolchain
4 participants
@memsharded @franramirez688 @czoido @RubenRBS