Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: parameter on trim_conandata to block the raise an exception when conandata.yml file doesn't exist #15829

Merged
merged 3 commits into from Mar 7, 2024

Conversation

ErniGH
Copy link
Contributor

@ErniGH ErniGH commented Mar 7, 2024

Changelog: Feature: Add a parameter to trim_conandata to avoid raising an exception when conandata.yml file doesn't exist.
Docs: conan-io/docs#3624

Close: #15672

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.

@ErniGH ErniGH added this to the 2.2.0 milestone Mar 7, 2024
@ErniGH ErniGH assigned RubenRBS and ErniGH and unassigned ErniGH Mar 7, 2024
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation LGTM, and I'd say the default is also what I'd thought, but lets make sure we align on that.

@franramirez688 franramirez688 merged commit 4af94e3 into conan-io:develop2 Mar 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] Have trim_conandata not throw when there's no conandata.yml
6 participants