Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: remove existing 'file' arg when overwriting print #15912

Merged
merged 2 commits into from
Mar 22, 2024

Conversation

dasimmet
Copy link
Contributor

@dasimmet dasimmet commented Mar 21, 2024

Changelog: Fix: Fix broken calls to print(x, file=y) with duplicate keyword arguments.
Docs: Omit

To prevent this, when overwriting the print() function overwrite the existing 'file' argument

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

@CLAassistant
Copy link

CLAassistant commented Mar 21, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing this @dasimmet

Could you please sign the CLA?

I think the fix is good, and can be merged, maybe a unit test that covers this case could help to avoid future breakage. We can contribute the test if you want.

We might try to release this in a 2.2.2 release, I'll sync with the team.

@memsharded memsharded added this to the 2.2.2 milestone Mar 21, 2024
@memsharded
Copy link
Member

Could you please sign the CLA?

It is also possible that you did the commit with a different email rather than the one in your Github account, and that also confuses the CLA.

@dasimmet
Copy link
Contributor Author

Could you please sign the CLA?

It is also possible that you did the commit with a different email rather than the one in your Github account, and that also confuses the CLA.

Could you please sign the CLA?

It is also possible that you did the commit with a different email rather than the one in your Github account, and that also confuses the CLA.

yes i did and rewrote it now to my gh email.

Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much!

@memsharded
Copy link
Member

This might be released in a 2.2.2 patch depending on the impact. Can you easily fix/workaround it from your side?

@memsharded memsharded merged commit 937bfcc into conan-io:develop2 Mar 22, 2024
2 checks passed
@dasimmet
Copy link
Contributor Author

This might be released in a 2.2.2 patch depending on the impact. Can you easily fix/workaround it from your side?

yes, thanks. I can stay with 2.1 until it is released.

czoido pushed a commit to czoido/conan that referenced this pull request Mar 25, 2024
* remove existing 'file' arg when overwriting print

* add unittest for new_print override
czoido pushed a commit that referenced this pull request Mar 25, 2024
* remove existing 'file' arg when overwriting print

* add unittest for new_print override
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants