Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MesonToolchain reads conf tools.build:defines #16172

Merged

Conversation

franramirez688
Copy link
Contributor

@franramirez688 franramirez688 commented Apr 29, 2024

Changelog: Bugfix: Make MesonToolchain listen to tools.build:defines conf variable.
Docs: conan-io/docs#3709
Closes: #16169

@czoido czoido merged commit 2326609 into conan-io:develop2 Apr 29, 2024
2 checks passed
@paulharris
Copy link
Contributor

Did you also update the docs?
Specifically:

here (does not mention tools.build:defines)
https://docs.conan.io/2/reference/tools/meson/mesontoolchain.html#conf

And here:
https://docs.conan.io/2/reference/config_files/global_conf.html

tools.build:cxxflags: List of extra CXX flags used by different toolchains like CMakeToolchain, AutotoolsToolchain and MesonToolchain
tools.build:defines: List of extra definition flags used by different toolchains like CMakeToolchain and AutotoolsToolchain

It does not mention MesonToolchain in the list of toolchains - Meson IS mentioned in cxxflags, so it should also be mentioned in defines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] MesonToolchain ignores tools.build:defines ... and tc.preprocess_definitions quote problems
6 participants