Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pyinstaller #16186

Merged
merged 1 commit into from
May 2, 2024
Merged

fix pyinstaller #16186

merged 1 commit into from
May 2, 2024

Conversation

memsharded
Copy link
Member

Changelog: Fix: Solve issue in pyinstaller.py script, it will no longer install pip install pyinstaller, having it installed will be a precondition
Docs: Omit

Close #16076

@gjasny
Copy link
Contributor

gjasny commented Apr 30, 2024

Successfully tested the new error that suggests to install pyinstaller as well as a successful run with pyinstaller preinstalled.

@memsharded
Copy link
Member Author

Successfully tested the new error that suggests to install pyinstaller as well as a successful run with pyinstaller preinstalled.

Thanks for the feedback!

Copy link
Contributor

@jcar87 jcar87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@memsharded memsharded merged commit 3a07623 into conan-io:develop2 May 2, 2024
2 checks passed
@memsharded memsharded deleted the fix/pyinstaller branch May 2, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Cannot build v2.2.2 with Python 3.12
4 participants