Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only print info about cache'd recipe revision being newer when it truly is #16275

Merged

Conversation

AbrilRBS
Copy link
Member

@AbrilRBS AbrilRBS commented May 16, 2024

Changelog: Fix: Only print info about cached recipe revision being newer when it truly is.
Docs: Omit

Closes #16273

I still have to figure out how to best modify the test_update_binaries test that will fail in the CI

@AbrilRBS AbrilRBS changed the title Print info about cache rev being newer only when it truly is Print info about cache recpe rev being newer only when it truly is May 16, 2024
@AbrilRBS AbrilRBS changed the title Print info about cache recpe rev being newer only when it truly is Only print info about cache'd recipe revision being newer when it truly is May 16, 2024
@AbrilRBS AbrilRBS added this to the 2.4.0 milestone May 16, 2024
@AbrilRBS AbrilRBS closed this May 21, 2024
@AbrilRBS AbrilRBS deleted the rr/dont-say-newer-rev-for-same-timestamp branch May 21, 2024 16:01
@AbrilRBS AbrilRBS restored the rr/dont-say-newer-rev-for-same-timestamp branch May 21, 2024 16:04
@AbrilRBS AbrilRBS reopened this May 21, 2024
@AbrilRBS AbrilRBS marked this pull request as ready for review May 21, 2024 16:31
@memsharded memsharded self-assigned this May 22, 2024
@memsharded memsharded merged commit 40a7b65 into conan-io:develop2 May 22, 2024
2 checks passed
@AbrilRBS AbrilRBS deleted the rr/dont-say-newer-rev-for-same-timestamp branch May 22, 2024 16:16
franramirez688 pushed a commit to Neeeflix/conan that referenced this pull request May 29, 2024
…ly is (conan-io#16275)

* Print info about cache rev being newer only when it truly is

* Don't expect current install to be newer than cached one in test_update_binaries

* fix

---------

Co-authored-by: memsharded <james@conan.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[question] Why does an identical revision appear as "newer than the remote one"
2 participants