Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove find_package generation on test_package of cmake_lib template #16451

Merged
merged 2 commits into from
Jun 10, 2024
Merged

Remove find_package generation on test_package of cmake_lib template #16451

merged 2 commits into from
Jun 10, 2024

Conversation

perseoGI
Copy link
Contributor

@perseoGI perseoGI commented Jun 10, 2024 •
edited by czoido
Loading

Changelog: Fix: Avoid find_package's of transitive dependencies on test_package generated by cmake_lib template.
Docs: omit

Close #16450

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

On test_package/CMakeLists.txt should not appear any find_package of transitive dependencies (dependencies of the currently tested package) Delegate on conan cmake generators to find dependencies.

Also, ordered optional requirements and build_requirement methods on template

@perseoGI perseoGI added this to the 2.5.0 milestone Jun 10, 2024
@perseoGI perseoGI requested a review from memsharded June 10, 2024 09:31
@perseoGI perseoGI modified the milestones: 2.5.0, 2.4.1 Jun 10, 2024
@memsharded memsharded changed the base branch from develop2 to release/2.4 June 10, 2024 09:40
perseoGI and others added 2 commits June 10, 2024 11:55
@perseoGI
Remove find_package generation on test_package of cmake_lib template
1c3b3b3 
On test_package/CMakeLists.txt should not appear any find_package of
transitive dependencies (dependencies of the currently tested package)
Delegate on conan cmake generators to find dependencies.

Also, ordered optional requirements and build_requirement methods on
template
@czoido @perseoGI
Conan 2.4.1
75417c8
@perseoGI perseoGI force-pushed the 16450-fix-cmake_lib-template branch from e66a15f to 75417c8 Compare June 10, 2024 09:59
memsharded
memsharded approved these changes Jun 10, 2024
View reviewed changes
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think bumping the minor is managed by @czoido when doing the release.

@memsharded memsharded assigned czoido and unassigned memsharded Jun 10, 2024
@czoido czoido merged commit 34a2a31 into conan-io:release/2.4 Jun 10, 2024
2 checks passed
@czoido czoido mentioned this pull request Jun 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czoido czoido czoido approved these changes

@memsharded memsharded memsharded approved these changes

Assignees

@czoido czoido

Labels
None yet
Projects
None yet
Milestone
2.4.1
Development

Successfully merging this pull request may close these issues.

[bug] cmake_lib template adds find_package to all requirements in test_package
3 participants
@perseoGI @czoido @memsharded