Don't fail when we can't overwrite the summary file in the backup upload #16452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
memsharded
approved these changes
Jun 10, 2024
| # Always upload summary .json but only upload blob if it does not already exist | ||
| if file.endswith(".json") or not uploader.exists(full_url, auth=None): | ||
| output.info(f"Uploading file '{basename}' to backup sources server") | ||
| if is_summary or not uploader.exists(full_url, auth=None): |
There was a problem hiding this comment.
Do we want to gracefully compare the existing summary file in the remote, and use the comparison for the warning?
|
Thanks, @RubenRBS! |
memsharded
approved these changes
Jun 13, 2024
|
@jave27 merged, this will be in next Conan 2.5 release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Fix: Don't fail when we can't overwrite the summary file in the backup upload.
Docs: Omit
Missing tests