Feature/2756 #2847
Merged
Feature/2756 #2847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
lasote
reviewed
May 3, 2018
conans/test/util/pkg_config_test.py
Outdated
| if platform.system() == "Windows": | ||
| return | ||
| pc_content = """prefix=/my_prefix/path | ||
| libdir=/my_absoulte_path/fake/mylib/lib |
There was a problem hiding this comment.
be careful with the indentation.
lasote
approved these changes
May 3, 2018
memsharded
approved these changes
May 3, 2018
grisumbras
pushed a commit
to grisumbras/conan
that referenced
this pull request
Dec 27, 2018
* Fix abs paths with pkg_config generator * removed short_paths from recipe in test * Added rpaths flags to pkg-config generator * removed _with_prefix and updated test * improved tests * Auxiliary function to generate dir lines * improved test as per review * fix libdirs * fix for rpaths * remove vars not needed * Added tests * test pkg-config return libs * Added quotes to tests * Fix pkg-config check * moved test * Reverted changes in compiler flags * fixed indentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
developbranch, documenting this one. Also adding a description of the changes in thechangelog.rstfile. https://github.com/conan-io/docs