Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New and improved generator for B2 (Boost Build). #3416

Merged
merged 3 commits into from Sep 20, 2018
Merged

New and improved generator for B2 (Boost Build). #3416

merged 3 commits into from Sep 20, 2018

Conversation

grafikrobot
Copy link
Contributor

@grafikrobot grafikrobot commented Aug 28, 2018 •
edited by lasote

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one. Also adding a description of the changes in the changelog.rst file. https://github.com/conan-io/docs

Related documentation PR is conan-io/docs#790

Changelog: Feature: New b2 generator. It replaces the old incomplete boost_build generator that is now deprecated.

@ghost ghost added the contributor pr label Aug 28, 2018
@grafikrobot grafikrobot mentioned this pull request Aug 28, 2018
Closed
5 tasks
@lasote lasote added this to the 1.8 milestone Sep 12, 2018
memsharded
memsharded approved these changes Sep 17, 2018
View reviewed changes
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good job, thanks!
I can't understand the details of the b2, but trust you in this regard :)

So I vote for merging and releasing it as experimental in next 1.8, so it can be iterated in the following releases if necessary.

conans/client/generators/b2.py Show resolved Hide resolved
conans/test/generators/b2_test.py Outdated Show resolved Hide resolved
@lasote lasote merged commit 60df43a into conan-io:develop Sep 20, 2018
@ghost ghost removed the stage: review label Sep 20, 2018
@lasote
Copy link
Contributor

lasote commented Sep 20, 2018

Yes, I agree. Let's release it as EXPERIMENTAL to iterate it easier in case we need to change some interface. Thanks, Rene!

@solvingj
Copy link
Contributor

solvingj commented Oct 9, 2018

Great Work!

grisumbras pushed a commit to grisumbras/conan that referenced this pull request Dec 27, 2018
@grafikrobot @lasote
New and improved generator for B2 (Boost Build). (conan-io#3416)
d1f17d0 
* New and improved generator for B2 (Boost Build).

* Fix typo for gnu98 cppstd setting.

* Cleanup from review feedback.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@memsharded memsharded memsharded approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.8
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@grafikrobot @lasote @solvingj @memsharded