Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add relative config install #3468

Merged

Conversation

@Minimonium
Copy link
Contributor

@Minimonium Minimonium commented Sep 3, 2018

Implements #3467

Should I change _make_abs_path to check that the path provided exists, it's a path to a folder/file?

Changelog: Feature: The command conan config install now support relative paths.

@ghost ghost added the contributor pr label Sep 3, 2018
@memsharded
Copy link
Member

@memsharded memsharded commented Sep 4, 2018

Should I change _make_abs_path to check that the path provided exists, it's a path to a folder/file?

Probably not, as it might be used to compute the abs path of some folder/file that might be created later.

@memsharded memsharded merged commit f6d7894 into conan-io:develop Sep 4, 2018
2 checks passed
@ghost ghost removed the contributor pr label Sep 4, 2018
@memsharded memsharded added this to the 1.8 milestone Sep 4, 2018
@memsharded
Copy link
Member

@memsharded memsharded commented Sep 4, 2018

Thanks for fixing this!

grisumbras pushed a commit to grisumbras/conan that referenced this issue Dec 27, 2018
…_config_install

Feature/add relative config install
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants