Add get_repo_root to SCM, use it for path stored in scm_folder.txt (close #3465) #3479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
This was referenced Sep 4, 2018
danimtb
approved these changes
Sep 6, 2018
lasote
reviewed
Sep 6, 2018
conans/test/functional/scm_test.py
Outdated
| """ | ||
| curdir = self.client.current_folder | ||
| conanfile = base.format(url="auto", revision="auto") | ||
| self.client.save({"conanfile.py": conanfile}, |
There was a problem hiding this comment.
You can run self.client.save({"conan/conanfile.py": conanfile})
There was a problem hiding this comment.
And mix with "myfile.txt" save for clarity.
There was a problem hiding this comment.
much better, didn't thought about that 🙃
lasote
reviewed
Sep 6, 2018
| # Create the package | ||
| self.client.run("create conan/ user/channel") | ||
| sources_dir = self.client.client_cache.scm_folder(self.reference) | ||
| self.assertEquals(load(sources_dir), curdir.replace('\\', '/')) # Root of git is 'curdir' |
There was a problem hiding this comment.
scm_folder is the name given by Conan to the scm_folder.txt file, I agree with you that it may not be the best one.
lasote
approved these changes
Sep 6, 2018
grisumbras
pushed a commit
to grisumbras/conan
that referenced
this pull request
Dec 27, 2018
Add get_repo_root to SCM, use it for path stored in scm_folder.txt (close conan-io#3465)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Bugfix: The
scmfeature now looks for the repo root even when theconanfile.pyis in a subfolder.