Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Feature/fix os walk py2 #3505
Based on the fact: When py2 uses
Changelog: BugFix: Fixed failures when Conan walk directories with files containing not ASCCI characters in the file name.
referenced this pull request
Sep 21, 2018
I'm trying to make a snippet that fails to check that this PR is solving an issue and everything I tried runs ok (MacOS, py 2.7.15). Following the test you provided I'm making some changes to check that the issue actually exists and I thought that these lines below should fail:
badfilename = "\xE3\x81\x82badfile.txt" folder = temp_folder() filepath = os.path.join(folder, badfilename) save(to_file_bytes(filepath), "contents") a_file = [f for _, _, f in os.walk(unicode(folder))]
Maybe, does it depend on the locale?
@jgsogo Look at the py2 builds using directly
Pushing again with the correct code.
I've replayed builds (MacOS failed because of a CI issue): https://conan-ci.jfrog.info/blue/organizations/jenkins/ConanTestSuite/detail/PR-3505/10/pipeline I want to see what happens with py2.
Anyway, it may depend on locale, but these changes are necessary.