Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixing transitive private bug #3525

Merged
merged 1 commit into from Sep 17, 2018
Merged

fixing transitive private bug #3525

merged 1 commit into from Sep 17, 2018

Conversation

memsharded
Copy link
Member

@memsharded memsharded commented Sep 11, 2018 •
edited by lasote

fix #3523

Changelog: Bugfix: Fixed bug with transitive private dependencies.

@ghost ghost assigned memsharded Sep 11, 2018
@ghost ghost added the stage: review label Sep 11, 2018
@memsharded memsharded assigned lasote and unassigned memsharded Sep 11, 2018
@memsharded memsharded added this to the 1.8 milestone Sep 11, 2018
lasote
lasote approved these changes Sep 12, 2018
View reviewed changes
Copy link
Contributor

@lasote lasote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only "possible fix"? Anyway, merge it if ready.

@memsharded memsharded merged commit 8002cee into conan-io:develop Sep 17, 2018
@memsharded memsharded deleted the feature/fix_transitive_private branch September 17, 2018 08:27
@ghost ghost removed the stage: review label Sep 17, 2018
@memsharded memsharded mentioned this pull request Sep 17, 2018
Closed
3 tasks
grisumbras pushed a commit to grisumbras/conan that referenced this pull request Dec 27, 2018
@memsharded
Merge pull request conan-io#3525 from memsharded/feature/fix_transiti…
c5d0e3c 
…ve_private

fixing transitive private bug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lasote lasote lasote approved these changes

Assignees

@lasote lasote

Labels
None yet
Projects
None yet
Milestone
1.8
Development

Successfully merging this pull request may close these issues.

Resolved dependencies are not the same if a package needs to be built
2 participants
@memsharded @lasote