reduce propagate complexity from O(n2) to O(n) #3528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Do you have a script to generate that chain of dependencies (or even a complex graph)? I would want to try it and understand the underlying code a little bit more, not just review the dict comprehensions thing. Thanks! |
|
I am using https://github.com/conan-io/test/tree/master/conan_tests/performance to create a graph, then test manually over the created graph. |
jgsogo
approved these changes
Sep 11, 2018
grisumbras
pushed a commit
to grisumbras/conan
that referenced
this pull request
Dec 27, 2018
* reduce propagate complexity from O(n2) to O(n) * fixed sorted py2to3 issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on the CI reproducibility, graph locks, etc, I found very slow graph propagation. This PR will highly alleviate it.
Measured, for a linear graph (A->B->C-> .... ->) of 250 nodes, the propagation (computed by ConanInstaller), reduces from 30 to 3 seconds.
Changelog: Feature: Improved graph propagation performance from
O(n2)toO(n).