Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added python 2 deprecation notice #3567

Merged
merged 3 commits into from Sep 18, 2018
Merged

Conversation

danimtb
Copy link
Member

@danimtb danimtb commented Sep 18, 2018

Docs already have a python 2 deprecation notice

Changelog: Feature: Added python 2 deprecation message in the output of the conan commands.

image

@ghost ghost assigned danimtb Sep 18, 2018
@ghost ghost added the stage: review label Sep 18, 2018
@danimtb danimtb added this to the 1.8 milestone Sep 18, 2018
@danimtb danimtb assigned memsharded and unassigned danimtb Sep 18, 2018
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better keep it minimal at the moment, 1-2 warning lines in yellow should be enough. Tests broken because of extra output, thinking about it, it might affect some commands that people might be parsing the output (conan remote list, conan info --build-order, etc), but I don't think we have to commit on not changing the conan output in that case (cc/ @lasote)

@danimtb
Copy link
Member Author

danimtb commented Sep 18, 2018

Fine, will keep it short

@ghost ghost assigned danimtb Sep 18, 2018
@danimtb
Copy link
Member Author

danimtb commented Sep 18, 2018

image

Finally the message does NOT appear in commands with high probabilities of being parsed:

  • conan info
  • conan get
  • conan remote
  • conan config
  • conan user
  • conan search
  • conan profile

If you think there is any other that should not show the message just point it out here.

@memsharded memsharded merged commit cc3549f into conan-io:develop Sep 18, 2018
@ghost ghost removed the stage: review label Sep 18, 2018
grisumbras pushed a commit to grisumbras/conan that referenced this pull request Dec 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Print Warning for Python 2 in conan client
2 participants