Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added python 2 deprecation notice #3567

Merged
merged 3 commits into from Sep 18, 2018

Conversation

Projects
None yet
2 participants
@danimtb
Copy link
Member

commented Sep 18, 2018

  • Refer to the issue that supports this Pull Request: closes #3531
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one. Also adding a description of the changes in the changelog.rst file. https://github.com/conan-io/docs

Docs already have a python 2 deprecation notice

Changelog: Feature: Added python 2 deprecation message in the output of the conan commands.

image

@ghost ghost assigned danimtb Sep 18, 2018

@ghost ghost added the stage: review label Sep 18, 2018

@danimtb danimtb added this to the 1.8 milestone Sep 18, 2018

@danimtb danimtb assigned memsharded and unassigned danimtb Sep 18, 2018

@memsharded
Copy link
Contributor

left a comment

Better keep it minimal at the moment, 1-2 warning lines in yellow should be enough. Tests broken because of extra output, thinking about it, it might affect some commands that people might be parsing the output (conan remote list, conan info --build-order, etc), but I don't think we have to commit on not changing the conan output in that case (cc/ @lasote)

@danimtb

This comment has been minimized.

Copy link
Member Author

commented Sep 18, 2018

Fine, will keep it short

@ghost ghost assigned danimtb Sep 18, 2018

@danimtb

This comment has been minimized.

Copy link
Member Author

commented Sep 18, 2018

image

Finally the message does NOT appear in commands with high probabilities of being parsed:

  • conan info
  • conan get
  • conan remote
  • conan config
  • conan user
  • conan search
  • conan profile

If you think there is any other that should not show the message just point it out here.

@memsharded memsharded merged commit cc3549f into conan-io:develop Sep 18, 2018

2 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
license/cla Contributor License Agreement is signed.
Details

@ghost ghost removed the stage: review label Sep 18, 2018

grisumbras pushed a commit to grisumbras/conan that referenced this pull request Dec 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.