Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

- allow vcvars for clang-cl #3574

Merged
merged 13 commits into from Sep 27, 2018
Merged

- allow vcvars for clang-cl #3574

merged 13 commits into from Sep 27, 2018

Conversation

SSE4
Copy link
Contributor

@SSE4 SSE4 commented Sep 19, 2018 •
edited

Signed-off-by: SSE4 tomskside@gmail.com

related to the:
#1839
https://github.com/conan-community/community/issues/43

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one. Also adding a description of the changes in the changelog.rst file. https://github.com/conan-io/docs

Changelog: Feature: Allow vcvars to run if clang-cl compiler is detected.

@ghost ghost added the contributor pr label Sep 19, 2018
danimtb
danimtb reviewed Sep 19, 2018
View reviewed changes
conans/test/util/vcvars_clangcl_test.py Outdated Show resolved Hide resolved
conans/test/util/vcvars_clangcl_test.py Outdated Show resolved Hide resolved
conans/test/util/vcvars_clangcl_test.py Outdated Show resolved Hide resolved
@SSE4
- allow vcvars for clang-cl
6b59c11 
Signed-off-by: SSE4 <tomskside@gmail.com>
lasote
lasote approved these changes Sep 20, 2018
View reviewed changes
Copy link
Contributor

@lasote lasote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only concern is the breaking behavior, but prior to this PR, passing a non-visual studio compiler with whatever version could have unexpected results. So for me is ok.

@lasote lasote added this to the 1.8 milestone Sep 21, 2018
jgsogo
jgsogo suggested changes Sep 22, 2018
View reviewed changes
Copy link
Contributor

@jgsogo jgsogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will add also a test mocking the function vs_installation_path in order to test the new if/else clauses.

conans/client/tools/win.py Outdated Show resolved Hide resolved
conans/client/tools/win.py Outdated Show resolved Hide resolved
lasote
lasote requested changes Sep 24, 2018
View reviewed changes
conans/client/tools/win.py Outdated Show resolved Hide resolved
@SSE4
- move _visual_compiler_last from detect.py into win.py, renaming to …
11ac60a 
…the latest_visual_studio_version_installed

Signed-off-by: SSE4 <tomskside@gmail.com>
@SSE4
- look from the latest to oldest
41f2dfa 
Signed-off-by: SSE4 <tomskside@gmail.com>
@SSE4
- add negative test case
2e05a0a 
Signed-off-by: SSE4 <tomskside@gmail.com>
@SSE4
Copy link
Contributor Author

SSE4 commented Sep 24, 2018

@lasote @jgsogo added test with mocks, moved and renamed _visual_compiler_last

jgsogo
jgsogo suggested changes Sep 24, 2018
View reviewed changes
conans/client/tools/win.py Outdated Show resolved Hide resolved
conans/client/tools/win.py Outdated Show resolved Hide resolved
conans/client/tools/win.py Outdated Show resolved Hide resolved
@lasote
Copy link
Contributor

lasote commented Sep 25, 2018

Pending to open a PR in the docs with:

  • changelog
  • system_registry_key tool (reference/tools)
  • latest_visual_studio_version_installed (reference/tools)

@jgsogo
Copy link
Contributor

jgsogo commented Sep 25, 2018

After talking with @lasote, @SSE4, please document only latest_visual_studio_version_installed in reference/tools; but keep context manager system_registry_key undocumented and make it private (change name to _system_registry_key).

@SSE4
- make system_registry_key private
54fb6f4 
Signed-off-by: SSE4 <tomskside@gmail.com>
@SSE4
Copy link
Contributor Author

SSE4 commented Sep 26, 2018

made system_registry_key private, opened conan-io/docs#850

@SSE4 SSE4 mentioned this pull request Sep 26, 2018
Merged
danimtb
danimtb requested changes Sep 26, 2018
View reviewed changes
Copy link
Member

@danimtb danimtb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the value of having a _system_registry_key() function and it will come handy in some other detections and checks but we have to reduce the complexity of its usage

conans/client/tools/win.py Outdated Show resolved Hide resolved
conans/client/tools/win.py Show resolved Hide resolved
@SSE4
- return just Visual Studio version
c8bf59f 
Signed-off-by: SSE4 <tomskside@gmail.com>
@SSE4
- simplify _system_registry_key
2731984 
Signed-off-by: SSE4 <tomskside@gmail.com>
danimtb
danimtb approved these changes Sep 26, 2018
View reviewed changes
Copy link
Member

@danimtb danimtb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just small changes required 😃

conans/client/tools/win.py Outdated Show resolved Hide resolved
SSE4 and others added 2 commits September 26, 2018 15:57
@jgsogo jgsogo mentioned this pull request Sep 26, 2018
Merged
@SSE4
Merge pull request #9 from jgsogo/SSE-vcvars_clangcl
91959ff 
Try/catch for OpenKey and for QueryValue
jgsogo
jgsogo suggested changes Sep 26, 2018
View reviewed changes
conans/client/conf/detect.py Outdated Show resolved Hide resolved
@SSE4
- set detected compiler tuple properly
3b92aa8 
Signed-off-by: SSE4 <tomskside@gmail.com>
@jgsogo jgsogo merged commit 2b3e0e3 into conan-io:develop Sep 27, 2018
@ghost ghost removed the stage: review label Sep 27, 2018
grisumbras pushed a commit to grisumbras/conan that referenced this pull request Dec 27, 2018
@SSE4 @jgsogo
- allow vcvars for clang-cl (conan-io#3574)
dab7bf5 
* - allow vcvars for clang-cl

Signed-off-by: SSE4 <tomskside@gmail.com>

* - move _visual_compiler_last from detect.py into win.py, renaming to the latest_visual_studio_version_installed

Signed-off-by: SSE4 <tomskside@gmail.com>

* - look from the latest to oldest

Signed-off-by: SSE4 <tomskside@gmail.com>

* - add negative test case

Signed-off-by: SSE4 <tomskside@gmail.com>

* - handle latest_visual_studio_version_installed returns None

Signed-off-by: SSE4 <tomskside@gmail.com>

* - add system_registry_key context manager, ensure key is always closed

Signed-off-by: SSE4 <tomskside@gmail.com>

* - make system_registry_key private

Signed-off-by: SSE4 <tomskside@gmail.com>

* - return just Visual Studio version

Signed-off-by: SSE4 <tomskside@gmail.com>

* - simplify _system_registry_key

Signed-off-by: SSE4 <tomskside@gmail.com>

* - remove decorator

Signed-off-by: SSE4 <tomskside@gmail.com>

* try/catch for openKey and for QueryValue

* - set detected compiler tuple properly

Signed-off-by: SSE4 <tomskside@gmail.com>
@SSE4 SSE4 mentioned this pull request May 5, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgsogo jgsogo jgsogo approved these changes

@lasote lasote lasote approved these changes

@danimtb danimtb danimtb approved these changes

Assignees

@jgsogo jgsogo

Labels
None yet
Projects
None yet
Milestone
1.8
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@SSE4 @lasote @jgsogo @danimtb