Feature/reuse python scm #3576
Merged
Feature/reuse python scm #3576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
lasote
requested changes
Sep 20, 2018
conans/client/cmd/export.py
Outdated
| @@ -89,7 +90,33 @@ def _capture_export_scm_data(conanfile, conanfile_dir, destination_folder, outpu | |||
| # Generate the scm_folder.txt file pointing to the src_path | |||
| src_path = scm.get_repo_root() | |||
| save(scm_src_file, src_path.replace("\\", "/")) | |||
| scm_data.replace_in_file(os.path.join(destination_folder, "conanfile.py")) | |||
|
|
|||
There was a problem hiding this comment.
I would feel a bit more comfortable extracting this to a replace_scm function. The overall together is a bit scary.
lasote
approved these changes
Sep 21, 2018
grisumbras
pushed a commit
to grisumbras/conan
that referenced
this pull request
Dec 27, 2018
* adding test * AST scm replace * fixing replacement * more testing and fixing bugs * fixing tests * refactor replace code to function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix [python-requires] re-use scm variable for building from sources #3461
Changelog: Bugfix: Fixed
scmreplacement of the variable when exporting a conanfile.