Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- fix PowerPC architecture detection #3581

Merged
merged 1 commit into from Sep 20, 2018

Conversation

Projects
None yet
3 participants
@SSE4
Copy link
Contributor

commented Sep 20, 2018

Signed-off-by: SSE4 tomskside@gmail.com

related to the bincrafters/community#443
properly detects ppc64le architecture and few others
based on python's platform.machine(), which actually uses uname under the hood
tested on PowerPC VM
see also

  1. https://stackoverflow.com/questions/45125516/possible-values-for-uname-m
  2. https://en.wikipedia.org/wiki/Uname
  3. https://github.com/gcc-mirror/gcc/blob/master/config.guess
  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one. Also adding a description of the changes in the changelog.rst file. https://github.com/conan-io/docs

Changelog: Fix: More complete architecture list in the detection of the gnu triplet and the detection of the build machine architecture.

@ghost ghost added the contributor pr label Sep 20, 2018

@SSE4 SSE4 force-pushed the SSE4:ppc_architecture_detection branch from 12232e7 to a4a72aa Sep 20, 2018

Show resolved Hide resolved conans/client/tools/oss.py Outdated

@SSE4 SSE4 force-pushed the SSE4:ppc_architecture_detection branch from a4a72aa to f082511 Sep 20, 2018

- fix PowerPC architecture detection
Signed-off-by: SSE4 <tomskside@gmail.com>

@memsharded memsharded added this to the 1.8 milestone Sep 20, 2018

@lasote

lasote approved these changes Sep 20, 2018

@lasote lasote merged commit fd9ef9d into conan-io:develop Sep 20, 2018

2 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
license/cla Contributor License Agreement is signed.
Details

@ghost ghost removed the contributor pr label Sep 20, 2018

@SSE4

This comment has been minimized.

Copy link
Contributor Author

commented Sep 20, 2018

also related to the #3449

grisumbras pushed a commit to grisumbras/conan that referenced this pull request Dec 27, 2018

- fix PowerPC architecture detection (conan-io#3581)
Signed-off-by: SSE4 <tomskside@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.