Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not muted exception and added new archs for triplet detection #3603

Merged
merged 1 commit into from Sep 24, 2018

Conversation

@lasote
Copy link
Contributor

@lasote lasote commented Sep 24, 2018

  • Refer to the issue that supports this Pull Request.

Closes #3354

Changelog: Bugfix: Renamed os (reserved symbol) parameter to os_ in the get_gnu_triplet tool.
Changelog: Feature: Warning message printed if Conan cannot deduce an architecture of a GNU triplet.

@ghost ghost assigned lasote Sep 24, 2018
@ghost ghost added the stage: review label Sep 24, 2018
@lasote lasote added this to the 1.8 milestone Sep 24, 2018
@lasote lasote requested review from memsharded and danimtb and removed request for memsharded Sep 24, 2018
Copy link
Member

@memsharded memsharded left a comment

It might be breaking the rename of the argument os_: https://docs.conan.io/en/latest/reference/tools.html?highlight=get_gnu_triplet#tools-get-gnu-triplet though this should be considered a bug

lasote added a commit to lasote/docs that referenced this issue Sep 24, 2018
Copy link
Member

@danimtb danimtb left a comment

My mistake on the os_ renaming issue. Agree the change is needed.

@lasote lasote merged commit 85a41a2 into conan-io:develop Sep 24, 2018
2 checks passed
@ghost ghost removed the stage: review label Sep 24, 2018
danimtb added a commit to conan-io/docs that referenced this issue Oct 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants