Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix output overlap of decompress progress and plugins #3622

Merged
merged 1 commit into from Sep 27, 2018

Conversation

Projects
None yet
3 participants
@danimtb
Copy link
Member

commented Sep 26, 2018

  • Refer to the issue that supports this Pull Request: closes #3607
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.

The decompress output made the plugin trace look like this:

C:\Users\danimtb\.conan\data\box2d\2.3.1\danimtb\testing\source
[==================================================] 1.8MB/1.8MB
Unzipping 6.0MB, this can take a while
Unzipping 99 %                                                        [PLUGIN - conan-center] post_source(): [LIBCXX] OK
box2d/2.3.1@danimtb/testing: Copying sources to build folder

Now it shoes like:

box2d/2.3.1@danimtb/testing: Configuring sources in C:\Users\danimtb\.conan\data\box2d\2.3.1\danimtb\testing\source
[==================================================] 1.8MB/1.8MB
Unzipping 6.0MB, this can take a while
Unzipping 100 %
[PLUGIN - conan-center] post_source(): [LIBCXX] OK
box2d/2.3.1@danimtb/testing: Copying sources to build folder

Unfortunately this is only produced in terminals with TTY so I was not able to reproduce it in a test.

Changelog: BugFix: Fix output overlap of decompress progress and plugins

@danimtb danimtb added this to the 1.8 milestone Sep 26, 2018

@ghost ghost assigned danimtb Sep 26, 2018

@ghost ghost added the stage: review label Sep 26, 2018

@danimtb danimtb assigned jgsogo and unassigned danimtb Sep 26, 2018

@jgsogo

jgsogo approved these changes Sep 26, 2018

Copy link
Member

left a comment

Ok, but it eventually should be overriden by tqdm progress bars.

@lasote lasote merged commit 655b937 into conan-io:develop Sep 27, 2018

2 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
license/cla Contributor License Agreement is signed.
Details

@ghost ghost removed the stage: review label Sep 27, 2018

grisumbras pushed a commit to grisumbras/conan that referenced this pull request Dec 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.