AST parsing in python 2 with encoding and shebang #3750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
memsharded
reviewed
Oct 15, 2018
| # Workaround for https://bugs.python.org/issue22221 | ||
| lines_without_headers = [] | ||
| lines = content.splitlines(True) | ||
| for line in lines: |
There was a problem hiding this comment.
It is not enough to remove the # encoding line?
There was a problem hiding this comment.
I put it later in the file to be able to parse/evaluate it... it can have non-ascii chars (and it reminds me that I need to add that in the test file! Thanks!)
There was a problem hiding this comment.
it already has non-ascii chars... there are several ¡Ñandú! as authors... 😆
grisumbras
pushed a commit
to grisumbras/conan
that referenced
this pull request
Dec 27, 2018
* fix issue conan-io#3749 reported by @hanickadot * do not split twice if not py2 * if there aren't headers, do not add a blank line * handle blank lines at the end of file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Bugfix: AST parsing of
conanfile.pywith shebang and encoding header lines was failing in python 2. This fix also allows non-ascii chars inconanfile.pyif proper encoding is declared.