Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Premake generator #3751

Merged
merged 9 commits into from Oct 19, 2018

Conversation

Projects
None yet
4 participants
@SSE4
Copy link
Contributor

commented Oct 15, 2018

closes #3693

uses premake generator from https://github.com/memsharded/conan-premake

Changelog: Feature: New premake generator incorporated to the Conan code base from the external generator at https://github.com/memsharded/conan-premake.

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

memsharded and others added some commits Apr 7, 2016

- rename Premake -> PremakeGenerator
Signed-off-by: SSE4 <tomskside@gmail.com>
- pep8
Signed-off-by: SSE4 <tomskside@gmail.com>
- remove unused code
Signed-off-by: SSE4 <tomskside@gmail.com>
- register the premake generator
Signed-off-by: SSE4 <tomskside@gmail.com>
- add test for premake generator
Signed-off-by: SSE4 <tomskside@gmail.com>

@ghost ghost added the contributor pr label Oct 15, 2018

@lasote lasote added this to the 1.9 milestone Oct 15, 2018

@SSE4

This comment has been minimized.

Copy link
Contributor Author

commented Oct 15, 2018

seems to be infrastructure failure
python: can't open file '.ci/jenkins/runner.py': [Errno 2] No such file or directory

@memsharded
Copy link
Contributor

left a comment

Looks good. Needs to be labeled as "experimental" in the docs, please do so.
Thanks!

- use standard name convention (conanbuildinfo.lua instead of conanpr…
…emake.lua)

Signed-off-by: SSE4 <tomskside@gmail.com>
@SSE4

This comment has been minimized.

Copy link
Contributor Author

commented Oct 16, 2018

I've played a bit with it, and some thoughts:

  • it's probably worth to add multi-configuration packages support, just like qmake has
  • it also worth providing premake_multi generator in addition to the premake (same way as visual_studio_mutli and cmake_multi)
  • finally, it might be worth providing conan_basic_setup function/macro to automatically set all flags
@danimtb

This comment has been minimized.

Copy link
Member

commented Oct 17, 2018

I think those are good ideas and would be helpful for premake users. I will keep them open in an issue and see if there is more feedback from people using it whne the generator is released. WDYT @SSE4 ?

@SSE4

This comment has been minimized.

Copy link
Contributor Author

commented Oct 17, 2018

yes, let's keep them for a while, until there is a real demand for them. I am not a premake user, so it's hard to judge for me.

@lasote lasote merged commit e717bb8 into conan-io:develop Oct 19, 2018

2 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
license/cla Contributor License Agreement is signed.
Details

@ghost ghost removed the contributor pr label Oct 19, 2018

grisumbras pushed a commit to grisumbras/conan that referenced this pull request Dec 27, 2018

Feature: Premake generator (conan-io#3751)
* initial example working

* fixed problem with deps with -

* Fixed identation and imports

* - rename Premake -> PremakeGenerator

Signed-off-by: SSE4 <tomskside@gmail.com>

* - pep8

Signed-off-by: SSE4 <tomskside@gmail.com>

* - remove unused code

Signed-off-by: SSE4 <tomskside@gmail.com>

* - register the premake generator

Signed-off-by: SSE4 <tomskside@gmail.com>

* - add test for premake generator

Signed-off-by: SSE4 <tomskside@gmail.com>

* - use standard name convention (conanbuildinfo.lua instead of conanpremake.lua)

Signed-off-by: SSE4 <tomskside@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.