Enable "unhack" user and channel #3758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
lasote
changed the title
|
Maybe properties/attributes instead of functions? (Should be the same as the proposed |
|
I just commented in here that probably the same fix is suitable for the 4 reference fields. And yes, attributes/properties are better. Changing it. |
jgsogo
approved these changes
Oct 16, 2018
danimtb
approved these changes
Oct 16, 2018
|
Update changelog description |
|
Looks good to me 👍 |
grisumbras
pushed a commit
to grisumbras/conan
that referenced
this pull request
Dec 27, 2018
* Enabled unhack user and channel * Changed to properties * Simple attributes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Feature: New attributes
default_useranddefault_channelthat can be declared in a conanfile to specify theuserandchannelfor conan local methods when neitherCONAN_USERNAMEandCONAN_CHANNELenvironment variables exist.