Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable "unhack" user and channel #3758

Merged

Conversation

Projects
None yet
5 participants
@lasote
Copy link
Contributor

commented Oct 16, 2018

Changelog: Feature: New attributes default_user and default_channel that can be declared in a conanfile to specify the user and channel for conan local methods when neither CONAN_USERNAME and CONAN_CHANNEL environment variables exist.

  • Refer to the issue that supports this Pull Request. #3697

@ghost ghost assigned lasote Oct 16, 2018

@ghost ghost added the stage: review label Oct 16, 2018

@lasote lasote changed the title Enabled unhack user and channel Enable "unhack" user and channel Oct 16, 2018

@lasote lasote added this to the 1.8.3 milestone Oct 16, 2018

@jgsogo

This comment has been minimized.

Copy link
Member

commented Oct 16, 2018

Maybe properties/attributes instead of functions? (Should be the same as the proposed default_version in the other issue)

@lasote

This comment has been minimized.

Copy link
Contributor Author

commented Oct 16, 2018

I just commented in here that probably the same fix is suitable for the 4 reference fields. And yes, attributes/properties are better. Changing it.

lasote added some commits Oct 16, 2018

@jgsogo

jgsogo approved these changes Oct 16, 2018

@danimtb

This comment has been minimized.

Copy link
Member

commented Oct 16, 2018

Update changelog description

@Aalmann

This comment has been minimized.

Copy link

commented Oct 16, 2018

Looks good to me 👍

@memsharded memsharded assigned memsharded and unassigned lasote Oct 16, 2018

@lasote lasote merged commit 54a1d2a into conan-io:release/1.8.3 Oct 16, 2018

2 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
license/cla Contributor License Agreement is signed.
Details

@ghost ghost removed the stage: review label Oct 16, 2018

grisumbras pushed a commit to grisumbras/conan that referenced this pull request Dec 27, 2018

Enable "unhack" user and channel (conan-io#3758)
* Enabled unhack user and channel

* Changed to properties

* Simple attributes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.