using profile or settings in export-pkg allowed #3768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
This was referenced Oct 17, 2018
lasote
approved these changes
Oct 17, 2018
grisumbras
pushed a commit
to grisumbras/conan
that referenced
this pull request
Dec 27, 2018
…kg_id using profile or settings in export-pkg allowed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Fix: Allow providing
--profileargument (and settings, options, env, too) toconan export-pkg, so it is able to correctly compute the binary package_id in case the information captured in the installed conaninfo.txt in previousconan installdoes not contain all information to reconstruct the graph.Close What causes error message: ERROR: <pkg-name> 'settings.arch' value not defined? #3367
Docs in conan-io/docs#898
There is no information enough in conaninfo.txt to recover all cases, and compute the whole dependency graph, which is necessary for correctly computing the package_id of the binary being exported. So this PR allows to specify the profile (or settings, options, env) that define the binary, instead of trying to recover it from the installed conaninfo.txt