Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using profile or settings in export-pkg allowed #3768

Merged
merged 1 commit into from Oct 19, 2018

Conversation

Projects
None yet
2 participants
@memsharded
Copy link
Contributor

commented Oct 17, 2018

Changelog: Fix: Allow providing --profile argument (and settings, options, env, too) to conan export-pkg, so it is able to correctly compute the binary package_id in case the information captured in the installed conaninfo.txt in previous conan install does not contain all information to reconstruct the graph.

  • Refer to the issue that supports this Pull Request.
    Close #3367

Docs in conan-io/docs#898

There is no information enough in conaninfo.txt to recover all cases, and compute the whole dependency graph, which is necessary for correctly computing the package_id of the binary being exported. So this PR allows to specify the profile (or settings, options, env) that define the binary, instead of trying to recover it from the installed conaninfo.txt

@lasote

lasote approved these changes Oct 17, 2018

@memsharded memsharded merged commit 26bc59b into conan-io:develop Oct 19, 2018

2 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
license/cla Contributor License Agreement is signed.
Details

@memsharded memsharded deleted the memsharded:feature/fix_export_pkg_id branch Oct 19, 2018

@ghost ghost removed the stage: review label Oct 19, 2018

grisumbras pushed a commit to grisumbras/conan that referenced this pull request Dec 27, 2018

Merge pull request conan-io#3768 from memsharded/feature/fix_export_p…
…kg_id

using profile or settings in export-pkg allowed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.