Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore line if it is empty #3830

Merged
merged 4 commits into from Oct 26, 2018

Conversation

Projects
None yet
4 participants
@jgsogo
Copy link
Member

commented Oct 23, 2018

Changelog: Fix: Ignore empty line when parsing output inside SVN::excluded_files function.

Substitutes #3828

lasote and others added some commits Oct 19, 2018

@ghost ghost assigned jgsogo Oct 23, 2018

@ghost ghost added the stage: review label Oct 23, 2018

@jgsogo jgsogo referenced this pull request Oct 23, 2018

Closed

[SVN] Ignore line if it is empty #3828

1 of 1 task complete

@jgsogo jgsogo added this to the 1.8.5 milestone Oct 23, 2018

@jgsogo jgsogo requested a review from memsharded Oct 23, 2018

@jgsogo jgsogo assigned lasote and unassigned jgsogo Oct 23, 2018

@lasote

This comment has been minimized.

Copy link
Contributor

commented Oct 26, 2018

What are we doing with this finally? minor or 1.9?

@lasote lasote modified the milestones: 1.8.5, 1.9 Oct 26, 2018

@memsharded memsharded changed the base branch from release/1.8.5 to develop Oct 26, 2018

@ghost ghost assigned memsharded Oct 26, 2018

@memsharded memsharded merged commit 3cd31dc into conan-io:develop Oct 26, 2018

2 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
license/cla Contributor License Agreement is signed.
Details

@ghost ghost removed the stage: review label Oct 26, 2018

@jgsogo jgsogo deleted the jgsogo:issue/3810-2 branch Oct 26, 2018

grisumbras pushed a commit to grisumbras/conan that referenced this pull request Dec 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.