Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue/3714 default profile arch #3841

Merged
merged 2 commits into from Oct 24, 2018
Merged

Issue/3714 default profile arch #3841

merged 2 commits into from Oct 24, 2018

Conversation

jgsogo
Copy link
Contributor

@jgsogo jgsogo commented Oct 24, 2018

Changelog: Fix: do not populate arch nor arch_build in autodetected profile if platform.machine returns an empty string.

@jgsogo jgsogo added this to the 1.9 milestone Oct 24, 2018
@ghost ghost assigned jgsogo Oct 24, 2018
@ghost ghost added the stage: review label Oct 24, 2018
@danimtb danimtb merged commit 9ceab64 into conan-io:develop Oct 24, 2018
@ghost ghost removed the stage: review label Oct 24, 2018
@jgsogo jgsogo deleted the issue/3714-default-profile-arch branch October 25, 2018 08:09
grisumbras pushed a commit to grisumbras/conan that referenced this pull request Dec 27, 2018
@jgsogo @danimtb
if platform.machine returns an empty string, do not add 'arch' neithe…
5d0dfe5 
…r 'arch_build' to default profile (conan-io#3841)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danimtb danimtb danimtb approved these changes

@memsharded memsharded Awaiting requested review from memsharded

Assignees

@jgsogo jgsogo

@danimtb danimtb

Labels
None yet
Projects
None yet
Milestone
1.9
Development

Successfully merging this pull request may close these issues.

Autodetected arch is empty, producing wrong default profile
2 participants
@jgsogo @danimtb