Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/improve upload recorder #3850

Merged
merged 3 commits into from Oct 26, 2018

Conversation

Projects
None yet
3 participants
@lasote
Copy link
Contributor

commented Oct 25, 2018

Changelog: Feature: Added remote_name and remote_url to upload json output.

  • Internally uses pure references to be able to extract more info
  • Prepared to show the revision if present
  • Different remotes for packages than the recipe, it could happen.

@lasote lasote requested a review from danimtb Oct 25, 2018

@ghost ghost assigned lasote Oct 25, 2018

@ghost ghost added the stage: review label Oct 25, 2018

@lasote lasote added this to the 1.9 milestone Oct 25, 2018

@danimtb

This comment has been minimized.

Copy link
Member

commented Oct 25, 2018

This will require an update of the docs and I think the changelog is relevant to at least let users know that the json has changed

@danimtb danimtb removed their assignment Oct 25, 2018

@danimtb danimtb referenced this pull request Oct 25, 2018

Merged

Updated upload json output #913

@danimtb
Copy link
Member

left a comment

I have created the PR to the docs for you. Please add a changelog

@lasote

This comment has been minimized.

Copy link
Contributor Author

commented Oct 25, 2018

The format is not changing while the user won't use revisions at all. So I think the docs and the changelog is not necessary.

@danimtb

This comment has been minimized.

Copy link
Member

commented Oct 25, 2018

but you are adding remote_name and remote_url fields to each package

@lasote lasote assigned memsharded and lasote and unassigned lasote and memsharded Oct 26, 2018

@memsharded memsharded merged commit a745b8f into conan-io:develop Oct 26, 2018

2 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
license/cla Contributor License Agreement is signed.
Details

@ghost ghost removed the stage: review label Oct 26, 2018

grisumbras pushed a commit to grisumbras/conan that referenced this pull request Dec 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.