Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/improve upload recorder #3850

Merged
merged 3 commits into from Oct 26, 2018
Merged

Feature/improve upload recorder #3850

merged 3 commits into from Oct 26, 2018

Conversation

lasote
Copy link
Contributor

@lasote lasote commented Oct 25, 2018 •
edited

Changelog: Feature: Added remote_name and remote_url to upload json output.

  • Internally uses pure references to be able to extract more info
  • Prepared to show the revision if present
  • Different remotes for packages than the recipe, it could happen.

@lasote lasote requested a review from danimtb October 25, 2018 09:32
@ghost ghost assigned lasote Oct 25, 2018
@ghost ghost added the stage: review label Oct 25, 2018
@lasote lasote added this to the 1.9 milestone Oct 25, 2018
@danimtb
Copy link
Member

danimtb commented Oct 25, 2018 •
edited

This will require an update of the docs and I think the changelog is relevant to at least let users know that the json has changed

@danimtb danimtb removed their assignment Oct 25, 2018
@danimtb danimtb mentioned this pull request Oct 25, 2018
Merged
danimtb
danimtb reviewed Oct 25, 2018
View reviewed changes
Copy link
Member

@danimtb danimtb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have created the PR to the docs for you. Please add a changelog

@lasote
Copy link
Contributor Author

lasote commented Oct 25, 2018

The format is not changing while the user won't use revisions at all. So I think the docs and the changelog is not necessary.

@danimtb
Copy link
Member

danimtb commented Oct 25, 2018

but you are adding remote_name and remote_url fields to each package

@lasote lasote assigned memsharded and lasote and unassigned lasote and memsharded Oct 26, 2018
@memsharded memsharded merged commit a745b8f into conan-io:develop Oct 26, 2018
@ghost ghost removed the stage: review label Oct 26, 2018
grisumbras pushed a commit to grisumbras/conan that referenced this pull request Dec 27, 2018
@memsharded
Merge pull request conan-io#3850 from lasote/feature/improve_upload_r…
07de941 
…ecord

Feature/improve upload recorder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danimtb danimtb danimtb left review comments

Assignees

@lasote lasote

@memsharded memsharded

Labels
None yet
Projects
None yet
Milestone
1.9
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lasote @danimtb @memsharded