Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make option --askpass compatible with sudo version 1.8.7 or older. #3885

Merged
merged 11 commits into from Oct 31, 2018

Conversation

Projects
None yet
5 participants
@yangcha
Copy link
Contributor

commented Oct 31, 2018

Changelog: Bugfix: sudo --askpass breaks Centos 6 package installation. The sudo version on Centos 6 is 1.8.6. The option of askpass for sudo version 1.8.7 or older is sudo -A.
sudo -A will work on almost every platforms.

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

tivek and others added some commits Oct 29, 2018

@ghost ghost added the contributor pr label Oct 31, 2018

@CLAassistant

This comment has been minimized.

Copy link

commented Oct 31, 2018

CLA assistant check
All committers have signed the CLA.

@yangcha yangcha changed the title make option --askpass compatible with sudo version 1.8.7 or older. Make option --askpass compatible with sudo version 1.8.7 or older. Oct 31, 2018

@lasote

lasote approved these changes Oct 31, 2018

Copy link
Contributor

left a comment

Thanks! we would try to include it in the next minor release.

@lasote lasote added this to the 1.9.1 milestone Oct 31, 2018

@lasote lasote changed the base branch from develop to release/1.9.1 Oct 31, 2018

@ghost ghost assigned lasote Oct 31, 2018

@ghost ghost added stage: review and removed contributor pr labels Oct 31, 2018

lasote added some commits Oct 31, 2018

Update .travis.yml
Revert to master branch

@lasote lasote merged commit 6f397ba into conan-io:release/1.9.1 Oct 31, 2018

1 check was pending

license/cla Contributor License Agreement is not signed yet.
Details

@ghost ghost removed the stage: review label Oct 31, 2018

@yangcha yangcha deleted the yangcha:bugfix/sudo-askpass branch Oct 31, 2018

grisumbras pushed a commit to grisumbras/conan that referenced this pull request Dec 27, 2018

Make option --askpass compatible with sudo version 1.8.7 or older. (c…
…onan-io#3885)

* fix Travis CI branch regex

* test Python 3.7 on Travis CI

* 1.10.0-dev

* make option --askpass compatible with sudo version 1.8.7 or older.

* Update .travis.yml

Revert to master branch

* Update Jenkinsfile

* Update .travis.yml

* Update __init__.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.