Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make option --askpass compatible with sudo version 1.8.7 or older. #3885

Merged
merged 11 commits into from Oct 31, 2018
Merged

Make option --askpass compatible with sudo version 1.8.7 or older. #3885

merged 11 commits into from Oct 31, 2018

Conversation

yangcha
Copy link
Contributor

@yangcha yangcha commented Oct 31, 2018 •
edited by lasote

Changelog: Bugfix: sudo --askpass breaks Centos 6 package installation. The sudo version on Centos 6 is 1.8.6. The option of askpass for sudo version 1.8.7 or older is sudo -A.
sudo -A will work on almost every platforms.

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

@ghost ghost added the contributor pr label Oct 31, 2018
@CLAassistant
Copy link

CLAassistant commented Oct 31, 2018 •
edited

CLA assistant check
All committers have signed the CLA.

@yangcha yangcha changed the title make option --askpass compatible with sudo version 1.8.7 or older. Make option --askpass compatible with sudo version 1.8.7 or older. Oct 31, 2018
lasote
lasote approved these changes Oct 31, 2018
View reviewed changes
Copy link
Contributor

@lasote lasote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! we would try to include it in the next minor release.

@lasote lasote added this to the 1.9.1 milestone Oct 31, 2018
@lasote lasote changed the base branch from develop to release/1.9.1 October 31, 2018 07:53
@ghost ghost assigned lasote Oct 31, 2018
@ghost ghost added stage: review and removed contributor pr labels Oct 31, 2018
@lasote lasote merged commit 6f397ba into conan-io:release/1.9.1 Oct 31, 2018
@ghost ghost removed the stage: review label Oct 31, 2018
@yangcha yangcha deleted the bugfix/sudo-askpass branch October 31, 2018 15:54
@jgsogo jgsogo mentioned this pull request Dec 3, 2018
Closed
grisumbras pushed a commit to grisumbras/conan that referenced this pull request Dec 27, 2018
@yangcha @lasote
Make option --askpass compatible with sudo version 1.8.7 or older. (c…
b922836 
…onan-io#3885)

* fix Travis CI branch regex

* test Python 3.7 on Travis CI

* 1.10.0-dev

* make option --askpass compatible with sudo version 1.8.7 or older.

* Update .travis.yml

Revert to master branch

* Update Jenkinsfile

* Update .travis.yml

* Update __init__.py
@uilianries uilianries mentioned this pull request Jul 3, 2019
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lasote lasote lasote approved these changes

Assignees

@lasote lasote

Labels
None yet
Projects
None yet
Milestone
1.9.1
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@yangcha @CLAassistant @lasote @tivek @memsharded