vcvars regression #3918
vcvars regression #3918
Conversation
ghost
assigned 
| # Keep the VS default, which is x86 toolset | ||
| # This will probably be changed in conan 2.0 | ||
| if ((settings.get_safe("arch_build") or | ||
| os.getenv("PreferredToolArchitecture") == "x64") |
There was a problem hiding this comment.
PreferredToolArchitecture is not an env var normally, right? in that case, I would name it CONAN_PREFERRED_TOOL_ARCHITECTURE. And it has to be documented (and mentioned in the changelog)
There was a problem hiding this comment.
It seems that it is an env-var: https://developercommunity.visualstudio.com/comments/282434/view.html, but I fail to find more compelling evidence on how is it used.
From: https://msdn.microsoft.com/en-us/library/ee662426.aspx
The PreferredToolArchitecture property determines whether the 32-bit or 64-bit compiler and tools are used in the build. This property does not affect the output platform architecture or configuration. By default, MSBuild uses the x86 version of the compiler and tools if this property is not set, or is set to any value other than x64.
Set the PreferredToolArchitecture property to x64 to use the 64-bit compiler and tools to build your application.
msbuild myProject.vcxproj /p:PreferredToolArchitecture=x64
There was a problem hiding this comment.
ok then. I can't find it either, just people saying it works but no-official docs. Anyway this is ok.
* vcvars regression * using env var PreferredToolArchitecture
Changelog: Fix: Fix regression introduced in 1.7, setting
amd64_x86when noarch_buildis defined.Close backward compatibility broken on vcvars command #3917
To pass CI, maybe a specific test that covers it is needed.