Feature/fix vcvars filter known #3941
Conversation
ghost
assigned
conans/client/tools/win.py
Outdated
| path = new_env.get("PATH", "").split(";") | ||
| path = [entry for entry in path if relevant_path(entry)] | ||
| new_env["PATH"] = ";".join(path) | ||
| path_key = ([name for name in new_env.keys() if "path" == name.lower()] or ["PATH"])[0] |
There was a problem hiding this comment.
The new_env["PATH"] is always a list, not a string (first bug)
There was a problem hiding this comment.
The name of the variable PATH could be in a different casing Path or path or PATH so check the correct one. (second bug)
conans/client/tools/win.py
Outdated
| path = new_env.get("PATH", "").split(";") | ||
| path = [entry for entry in path if relevant_path(entry)] | ||
| new_env["PATH"] = ";".join(path) | ||
| path_key = ([name for name in new_env.keys() if "path" == name.lower()] or ["PATH"])[0] |
There was a problem hiding this comment.
This will add "PATH" variable (empty) if it was not already there. Remove the or ... and check for path_key in order to add it to new_env or not in the following lines.
There was a problem hiding this comment.
Yes, but that was the previous behavior too. If we think that it shouldn't be added, that might be a breaking feature and a new issue for Conan 2.0 should be filed.
There was a problem hiding this comment.
It is a bug and not a big deal I think. I'm removing the assignment when path is empty.
conans/client/tools/win.py
Outdated
| path = new_env.get("PATH", "").split(";") | ||
| path = [entry for entry in path if relevant_path(entry)] | ||
| new_env["PATH"] = ";".join(path) | ||
| path_key = ([name for name in new_env.keys() if "path" == name.lower()] or ["PATH"])[0] |
There was a problem hiding this comment.
Yes, but that was the previous behavior too. If we think that it shouldn't be added, that might be a breaking feature and a new issue for Conan 2.0 should be filed.
|
Agree with the reviews. Please @lasote take a look |
* before win * added test * Avoid empty path
Changelog: Bugfix: Fixed bug in
vcvars_dicttool when usingfilter_known_pathsargument.