Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Make generator #4003

Merged
merged 7 commits into from Nov 28, 2018
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions conans/client/generators/__init__.py
Expand Up @@ -28,6 +28,7 @@
from conans.util.env_reader import get_env
from .b2 import B2Generator
from .premake import PremakeGenerator
from .make import MakeGenerator
danimtb marked this conversation as resolved.
Show resolved Hide resolved


class _GeneratorManager(object):
Expand Down Expand Up @@ -74,6 +75,7 @@ def __getitem__(self, key):
registered_generators.add("json", JsonGenerator)
registered_generators.add("b2", B2Generator)
registered_generators.add("premake", PremakeGenerator)
registered_generators.add("make", MakeGenerator)


def write_generators(conanfile, path, output):
Expand Down
122 changes: 122 additions & 0 deletions conans/client/generators/make.py
@@ -0,0 +1,122 @@
from conans.model import Generator


class MakeGenerator(Generator):

@property
def filename(self):
return "conanbuildinfo.mak"
danimtb marked this conversation as resolved.
Show resolved Hide resolved

@property
def content(self):

content = [
"#-------------------------------------------------------------------#",
"# Makefile variables from Conan Dependencies #",
"#-------------------------------------------------------------------#",
"",
]

for line_as_list in self.create_deps_content():
content.append("".join(line_as_list))

content.append("#-------------------------------------------------------------------#")
content.append(self.makefile_newline)
return self.makefile_newline.join(content)

def create_deps_content(self):
deps_content = []
danimtb marked this conversation as resolved.
Show resolved Hide resolved
deps_content.extend(self.create_content_from_deps())
deps_content.extend(self.create_combined_content())
return deps_content

def create_content_from_deps(self):
content = []
for pkg_name, cpp_info in self.deps_build_info.dependencies:
content.extend(self.create_content_from_dep(pkg_name, cpp_info))
return content

def create_content_from_dep(self, pkg_name, cpp_info):

vars_info = [("ROOT", self.assignment_if_absent, [cpp_info.rootpath]),
("SYSROOT", self.assignment_if_absent, [cpp_info.sysroot]),
("INC_PATHS", self.assignment_append, cpp_info.include_paths),
("LIB_PATHS", self.assignment_append, cpp_info.lib_paths),
("BIN_PATHS", self.assignment_append, cpp_info.bin_paths),
("BUILD_PATHS", self.assignment_append, cpp_info.build_paths),
("RES_PATHS", self.assignment_append, cpp_info.res_paths),
("LIBS", self.assignment_append, cpp_info.libs),
("DEFINES", self.assignment_append, cpp_info.defines),
("CFLAGS", self.assignment_append, cpp_info.cflags),
("CPPFLAGS", self.assignment_append, cpp_info.cppflags),
("SHAREDLINKFLAGS", self.assignment_append, cpp_info.sharedlinkflags),
("EXELINKFLAGS", self.assignment_append, cpp_info.exelinkflags)]

return [self.create_makefile_var_pkg(var_name, pkg_name, operator, info)
for var_name, operator, info in vars_info]

def create_combined_content(self):
content = []
for var_name in self.all_dep_vars():
content.append(self.create_makefile_var_global(var_name, self.assignment_append,
self.create_combined_var_list(var_name)))
return content

def create_combined_var_list(self, var_name):
make_vars = []
for pkg_name, _ in self.deps_build_info.dependencies:
pkg_var = self.create_makefile_var_name_pkg(var_name, pkg_name)
make_vars.append("$({pkg_var})".format(pkg_var=pkg_var))
return make_vars

def create_makefile_var_global(self, var_name, operator, values):
make_var = [self.create_makefile_var_name_global(var_name)]
make_var.extend(self.create_makefile_var_common(operator, values))
return make_var

def create_makefile_var_pkg(self, var_name, pkg_name, operator, values):
make_var = [self.create_makefile_var_name_pkg(var_name, pkg_name)]
make_var.extend(self.create_makefile_var_common(operator, values))
return make_var

def create_makefile_var_common(self, operator, values):
return [operator, self.makefile_line_continuation, self.create_makefile_var_value(values),
self.makefile_newline]

@staticmethod
def create_makefile_var_name_global(var_name):
return "CONAN_{var}".format(var=var_name).upper()

@staticmethod
def create_makefile_var_name_pkg(var_name, pkg_name):
return "CONAN_{var}_{lib}".format(var=var_name, lib=pkg_name).upper()

def create_makefile_var_value(self, values):
formatted_values = [value.replace("\\", "/") for value in values]
return self.makefile_line_continuation.join(formatted_values)

@staticmethod
def all_dep_vars():
return ["rootpath", "sysroot", "inc_paths", "lib_paths", "bin_paths", "build_paths",
"res_paths", "libs", "defines", "cflags", "cppflags", "sharedlinkflags",
"exelinkflags"]

@property
def makefile_newline(self):
return "\n"

@property
def makefile_line_continuation(self):
return " \\\n"

@property
def assignment_immediate(self):
danimtb marked this conversation as resolved.
Show resolved Hide resolved
return " := "

@property
def assignment_if_absent(self):
return " ?= "

@property
def assignment_append(self):
return " += "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why properties and not plain attributes?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left it as it was. I think it is done that way to prevent any change in the content

1 change: 1 addition & 0 deletions conans/client/generators/premake.py
Expand Up @@ -3,6 +3,7 @@


class PremakeDeps(object):

def __init__(self, deps_cpp_info):
self.include_paths = ",\n".join('"%s"' % p.replace("\\", "/")
for p in deps_cpp_info.include_paths)
Expand Down