correct/improve/simplify makefile unit test #4018
Changelog: Fix: Improve
The makefile generator unit test still had some small issues, summarized as they appear below. On one hand, the builds and tests passed, making these seem like mostly cosmetic issues. On the other hand, people sometimes look at tests, and probably moreso for new generators than anything else. Non-gcc experts might be confused about how they should use these flags/vars in their own makefiles, and gcc-experts might be concerned that the unit test does things incorrectly and still passes. Best to make these test as correct as possible.
-Thus, replaced the
-Simply removed the use of the
The text was updated successfully, but these errors were encountered:
Thanks @solvingj for the explanation. I think having a more realistic test is always a good thing.
Having a look at the variables I fail to see the same logic as described here: https://docs.conan.io/en/latest/reference/build_helpers/autotools.html#environment-variables
Which I think is the right convention as I explained with the table in here: conan-io/docs#955 (comment)
We need to reach an agreement or probably look more into it
* correct/improve/simplify makefile unit test * add proper use of CONAN_EXELINKFLAGS and CONAN_SHAREDLINKFLAGS, also, pass CFLAGS to linker rather than CPPFLAGS, eliminate superfluous LIBS var * map CONAN_CPPFLAGS to CXXFLAGS and implement fPIC and fPIE in test makefiles, remove typeo * fix LDLIBS var names and add to commands, remove CFLAGS from commands