Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate all download args to get #4041

Merged
merged 1 commit into from Dec 3, 2018
Merged

Conversation

@lasote
Copy link
Contributor

@lasote lasote commented Dec 3, 2018

Changelog: Fix: The tools.get tool (download + unzip) now supports all the arguments of the download tool. e.g: verify, retry, retry_wait etc.

Closes #4028
Docs at: conan-io/docs#961

@ghost ghost assigned lasote Dec 3, 2018
@ghost ghost added the stage: review label Dec 3, 2018
@lasote lasote added this to the 1.10 milestone Dec 3, 2018
@lasote lasote requested a review from danimtb Dec 3, 2018
@lasote lasote assigned danimtb and unassigned lasote Dec 3, 2018
danimtb
danimtb approved these changes Dec 3, 2018
auth=None, headers=None, requester=None):

if retry is None:
Copy link
Member

@memsharded memsharded Dec 3, 2018

why not the default to 2 in the argument?

Copy link
Contributor Author

@lasote lasote Dec 3, 2018

Well, I don't want to repeat the 2 and 5 in the tools.get. I think is more clear like this.

Copy link
Member

@danimtb danimtb Dec 3, 2018

I think it is to avoid propagating the default values to the upstream function, tools.get() in this case

@lasote lasote merged commit 25965f4 into conan-io:develop Dec 3, 2018
2 checks passed
@ghost ghost removed the stage: review label Dec 3, 2018
grisumbras pushed a commit to grisumbras/conan that referenced this issue Dec 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants