Propagate all download args to get #4041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
danimtb
approved these changes
Dec 3, 2018
memsharded
approved these changes
Dec 3, 2018
| auth=None, headers=None, requester=None): | ||
|
|
||
| if retry is None: |
There was a problem hiding this comment.
why not the default to 2 in the argument?
There was a problem hiding this comment.
Well, I don't want to repeat the 2 and 5 in the tools.get. I think is more clear like this.
There was a problem hiding this comment.
I think it is to avoid propagating the default values to the upstream function, tools.get() in this case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Fix: The
tools.gettool (download + unzip) now supports all the arguments of thedownloadtool. e.g:verify,retry,retry_waitetc.Closes #4028
Docs at: conan-io/docs#961