Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

better ConanFileReference checks #4044

Merged
merged 4 commits into from Dec 3, 2018
Merged

better ConanFileReference checks #4044

merged 4 commits into from Dec 3, 2018

Conversation

memsharded
Copy link
Member

Changelog: Bugfix: Better checks of package reference pkg/version@user/channel, avoids bugs for conanfile in 4 nested folders and conan install path/to/the/file

Close #3950

@ghost ghost assigned memsharded Dec 3, 2018
@ghost ghost added the stage: review label Dec 3, 2018
@memsharded memsharded added this to the 1.10 milestone Dec 3, 2018
@lasote lasote merged commit 57e1435 into conan-io:develop Dec 3, 2018
@ghost ghost removed the stage: review label Dec 3, 2018
@memsharded memsharded deleted the feature/better_ref_checks branch December 3, 2018 15:22
grisumbras pushed a commit to grisumbras/conan that referenced this pull request Dec 27, 2018
@memsharded @lasote
better ConanFileReference checks (conan-io#4044)
360bde8 
* better ConanFileReference checks

* fixing tests

* fix testsg

* fixing more tests
@petermbauer petermbauer mentioned this pull request Jan 14, 2019
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lasote lasote

@memsharded memsharded

Labels
None yet
Projects
None yet
Milestone
1.10
Development

Successfully merging this pull request may close these issues.

conan install fails to distinguish a path from a reference in some circumstances
2 participants
@memsharded @lasote