Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cautious treatment of compiler in b2 generator #4202

Merged

Conversation

Projects
None yet
4 participants
@grisumbras
Copy link
Contributor

commented Dec 26, 2018

Using settings.get_safe more actively. Conversion of Nones to strings.
Fixes #4201

Changelog: Bugfix: b2 generator was failing when package recipe didn't use compiler setting
Docs: omit

  • Refer to the issue that supports this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
cautious treatment of compiler in b2 generator
Using settings.get_safe more actively. Conversion of Nones to strings.
Fixes #4201
@CLAassistant

This comment has been minimized.

Copy link

commented Dec 26, 2018

CLA assistant check
All committers have signed the CLA.

@jgsogo jgsogo requested a review from danimtb Dec 27, 2018

@danimtb
Copy link
Member

left a comment

Thanks for the simplification! We are willing to review the whole b2 generator so this is very welcome 😄

@danimtb

This comment has been minimized.

Copy link
Member

commented Dec 27, 2018

Hi @grisumbras!

Thanks for your PR. Could you please include a brief changelog in the description of this PR? This will help us to include this in the next release. Thanks! 😃

@danimtb

This comment has been minimized.

Copy link
Member

commented Dec 27, 2018

Oh, I forgot to mention! It would be nice to write a test with the use case that was failing before this changes. I could help with it in case you are not familiar with them or don't have time. Just ping me!

@danimtb danimtb self-assigned this Dec 27, 2018

@danimtb danimtb added this to the 1.12 milestone Dec 27, 2018

@grisumbras

This comment has been minimized.

Copy link
Contributor Author

commented Dec 27, 2018

Should I prepend a commit with test or just add a commit?

@danimtb

This comment has been minimized.

Copy link
Member

commented Dec 27, 2018

An additional commit will be fine. We mostly review the diff so it doesn't matter that much

@grisumbras

This comment has been minimized.

Copy link
Contributor Author

commented Dec 27, 2018

Also, how should I create a ConanFile instance suitable for constructing a generator?

@danimtb

This comment has been minimized.

Copy link
Member

commented Dec 27, 2018

@grisumbras

This comment has been minimized.

Copy link
Contributor Author

commented Dec 27, 2018

I updated the PR description and added a test.

@danimtb
Copy link
Member

left a comment

Cool! Thanks @grisumbras

@danimtb danimtb merged commit db11550 into conan-io:develop Dec 27, 2018

2 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
license/cla Contributor License Agreement is signed.
Details

NoWiseMan added a commit to NoWiseMan/conan that referenced this pull request Jan 9, 2019

cautious treatment of compiler in b2 generator (conan-io#4202)
* cautious treatment of compiler in b2 generator

Using settings.get_safe more actively. Conversion of Nones to strings.
Fixes conan-io#4201

* test for b2 generator support of empty settings
@lasote

This comment has been minimized.

Copy link
Contributor

commented Jan 17, 2019

@danimtb please add the changelog and docs entries to this PR body.

@lasote

This comment has been minimized.

Copy link
Contributor

commented Jan 17, 2019

My bad, it was already there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.