New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cautious treatment of compiler in b2 generator #4202
cautious treatment of compiler in b2 generator #4202
Conversation
Using settings.get_safe more actively. Conversion of Nones to strings. Fixes conan-io#4201
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the simplification! We are willing to review the whole b2 generator so this is very welcome 😄
Hi @grisumbras! Thanks for your PR. Could you please include a brief changelog in the description of this PR? This will help us to include this in the next release. Thanks! 😃 |
Oh, I forgot to mention! It would be nice to write a test with the use case that was failing before this changes. I could help with it in case you are not familiar with them or don't have time. Just ping me! |
Should I prepend a commit with test or just add a commit? |
An additional commit will be fine. We mostly review the diff so it doesn't matter that much |
Also, how should I create a |
Have a look at https://github.com/conan-io/conan/blob/develop/conans/test/unittests/client/generators/b2_test.py I guess your test should be very similar |
I updated the PR description and added a test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! Thanks @grisumbras
* cautious treatment of compiler in b2 generator Using settings.get_safe more actively. Conversion of Nones to strings. Fixes conan-io#4201 * test for b2 generator support of empty settings
@danimtb please add the changelog and docs entries to this PR body. |
My bad, it was already there. |
Using settings.get_safe more actively. Conversion of Nones to strings.
Fixes #4201
Changelog: Bugfix: b2 generator was failing when package recipe didn't use compiler setting
Docs: omit