Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix add_cmake_flag in cmake helper #4227
Thanks very much for fixing this, indeed seems a bug. Just two things:
I just signed the CLA.
Sorry, I probably won't have time for the test. According to the file (which contains the only usages of the function), the only case where we add two flags (and may thus trigger a bug) is when using parallel build with MSVC, so the test should target that. Also, arch_flag seems to be added twice, not sure if that's intended.
I randomly stumbled upon the latent bug while reading the source and just wanted to report it :)
I happens that it is not possible to force that bug in a test. Fortunately, this shouldn't be affecting anyone. Appending calling
So I am merging it now, as it is an improvement anyway that could protect in the future. Thanks!
@lasote, if this is not actually used, should we refactor it?