Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: add definitions to MSBuild (and build_sln_command) #4239

Merged
merged 3 commits into from Jan 16, 2019

Conversation

Projects
None yet
4 participants
@SSE4
Copy link
Contributor

commented Jan 7, 2019

closes #4073

Changelog: Feature: add definitions to MSBuild build helper (and tools.build_sln_command())
Docs: conan-io/docs#1024

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.

/cc @solvingj

@ghost ghost assigned SSE4 Jan 7, 2019

@ghost ghost added the stage: review label Jan 7, 2019

@SSE4 SSE4 force-pushed the SSE4:msbuild_definitions branch 2 times, most recently from 30cbd47 to 24ae629 Jan 7, 2019

@solvingj

This comment has been minimized.

Copy link
Contributor

commented Jan 8, 2019

Amazing, looks really good and clean to me.

@SSE4

This comment has been minimized.

Copy link
Contributor Author

commented Jan 13, 2019

I gonna to update this to use MSBuild instead of build_sln_command in tests

SSE4 added some commits Jan 7, 2019

- add definitions to MSBuild (and build_sln_command)
Signed-off-by: SSE4 <tomskside@gmail.com>
- use MSBuild instead of build_sln_command in tests
Signed-off-by: SSE4 <tomskside@gmail.com>

@SSE4 SSE4 force-pushed the SSE4:msbuild_definitions branch from 24ae629 to 0fba66e Jan 13, 2019

@SSE4

This comment has been minimized.

Copy link
Contributor Author

commented Jan 13, 2019

updated tests to use MSBuild

@memsharded

This comment has been minimized.

Copy link
Contributor

commented Jan 16, 2019

Please fix conflicts when possible. Thanks!

@SSE4

This comment has been minimized.

Copy link
Contributor Author

commented Jan 16, 2019

fixed

@memsharded memsharded added this to the 1.12 milestone Jan 16, 2019

@memsharded memsharded merged commit 83e8ab9 into conan-io:develop Jan 16, 2019

2 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
license/cla Contributor License Agreement is signed.
Details

@ghost ghost removed the stage: review label Jan 16, 2019

@lasote

This comment has been minimized.

Copy link
Contributor

commented Jan 17, 2019

Missing docs? Missing "Doc: XXX" tag

@SSE4

This comment has been minimized.

Copy link
Contributor Author

commented Jan 17, 2019

added docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.