Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/cleaner config install #4259

Merged
merged 3 commits into from Jan 15, 2019

Conversation

@NoWiseMan
Copy link
Contributor

@NoWiseMan NoWiseMan commented Jan 9, 2019

Changelog: Feature: Skip "README.md" and "LICENSE.txt" during the installation of a custom config via conan config install.

Docs: conan-io/docs#1016

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

This fixes #4258

The first line explains the changes

@CLAassistant
Copy link

@CLAassistant CLAassistant commented Jan 9, 2019

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@memsharded memsharded left a comment

I am fine with this PR, it makes sense to skip those files.

Please add a note to the docs repo in a PR to develop branch.

One underlying issue is that conan-config-install works with multiple sources, but only caches and manages the last one. Some explicit representation of multiple conan-config-install sources might make sense, but that should be discussed separately.

Thanks for your contribution!

@ghost ghost assigned memsharded Jan 11, 2019
@ghost ghost added the stage: review label Jan 11, 2019
@NoWiseMan
Copy link
Contributor Author

@NoWiseMan NoWiseMan commented Jan 14, 2019

add PR to docs repro

@lasote lasote merged commit f746ce8 into conan-io:develop Jan 15, 2019
2 checks passed
@ghost ghost removed the stage: review label Jan 15, 2019
@NoWiseMan NoWiseMan deleted the feature/cleanerConfigInstall branch Jan 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants