Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: define environment variables for CTest #4299

Merged
merged 2 commits into from Jan 15, 2019

Conversation

@SSE4
Copy link
Contributor

@SSE4 SSE4 commented Jan 14, 2019

closes #3511

Changelog: Feature: define environment variables for CTest
Docs: conan-io/docs#1018

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.

/cc @cjdb

Signed-off-by: SSE4 <tomskside@gmail.com>
@ghost ghost assigned SSE4 Jan 14, 2019
@ghost ghost added the stage: review label Jan 14, 2019
Signed-off-by: SSE4 <tomskside@gmail.com>
@memsharded
Copy link
Member

@memsharded memsharded commented Jan 15, 2019

Looks good!

Please add it to the docs, and update the above https://github.com/conan-io/docs/pull/XXXX with the matching PR and I will merge this for next release. Thanks!

@memsharded memsharded added this to the 1.12 milestone Jan 15, 2019
@SSE4
Copy link
Contributor Author

@SSE4 SSE4 commented Jan 15, 2019

will do soon

@cjdb
Copy link

@cjdb cjdb commented Jan 15, 2019

Wonderful, thank you @SSE4!

@SSE4
Copy link
Contributor Author

@SSE4 SSE4 commented Jan 15, 2019

docs added

@memsharded memsharded merged commit 2b3bd4b into conan-io:develop Jan 15, 2019
2 checks passed
@ghost ghost removed the stage: review label Jan 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants