Fix: ensure is_windows, detect_windows_subsystem, uname work under MSYS/Cygwin #4313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
SSE4
force-pushed
the
fix_windows_shells
branch
2 times, most recently
from
b78e398
to
8db4362
Compare
…Cygwin shells Signed-off-by: SSE4 <tomskside@gmail.com>
SSE4
force-pushed
the
fix_windows_shells
branch
from
8db4362
to
6916dac
Compare
memsharded
approved these changes
Jan 15, 2019
jgsogo
suggested changes
Jan 16, 2019
Signed-off-by: SSE4 <tomskside@gmail.com>
5 tasks
Signed-off-by: SSE4 <tomskside@gmail.com>
Signed-off-by: SSE4 <tomskside@gmail.com>
|
it failed with weird error |
memsharded
reviewed
Jan 17, 2019
| @@ -0,0 +1,3 @@ | |||
| #!/usr/bin/env python | |||
| # -*- coding: utf-8 -*- | |||
| # vim: tabstop=8 expandtab shiftwidth=4 softtabstop=4 | |||
There was a problem hiding this comment.
Hi @SSE4
Please try to avoid adding this vim-only line to all the files.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4312
Changelog: Fix: ensure is_windows, detect_windows_subsystem, uname work under MSYS/Cygwin
Docs: omit
developbranch, documenting this one.Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.