Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: ensure tools.environment_append doesn't raise trying to unset variables #4324

Merged
merged 2 commits into from Jan 17, 2019
Merged

Fix: ensure tools.environment_append doesn't raise trying to unset variables #4324

merged 2 commits into from Jan 17, 2019

Conversation

SSE4
Copy link
Contributor

@SSE4 SSE4 commented Jan 16, 2019 •
edited

closes #4323

Changelog: Fix: ensure tools.environment_append doesn't raise trying to unset variables
Docs: conan-io/docs#1023

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.

@SSE4
- ensure tools.environment_append doesn't raise trying to unset varia…
65c745b 
…bles

Signed-off-by: SSE4 <tomskside@gmail.com>
@ghost ghost assigned SSE4 Jan 16, 2019
@ghost ghost added the stage: review label Jan 16, 2019
lasote
lasote reviewed Jan 17, 2019
View reviewed changes
conans/client/tools/env.py Outdated Show resolved Hide resolved
lasote
lasote requested changes Jan 17, 2019
View reviewed changes
Copy link
Contributor

@lasote lasote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the pop

@lasote lasote added this to the 1.12 milestone Jan 17, 2019
@lasote
Copy link
Contributor

lasote commented Jan 17, 2019

Missing docs PR

@SSE4 SSE4 mentioned this pull request Jan 17, 2019
Merged
@SSE4
Copy link
Contributor Author

SSE4 commented Jan 17, 2019

docs added

@lasote lasote merged commit 0e3d03b into conan-io:develop Jan 17, 2019
@ghost ghost removed the stage: review label Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lasote lasote lasote requested changes

Assignees

@SSE4 SSE4

Labels
None yet
Projects
None yet
Milestone
1.12
Development

Successfully merging this pull request may close these issues.

tools.environment_append raises if tries to unset variable which was never set
2 participants
@SSE4 @lasote