Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: ensure tools.environment_append doesn't raise trying to unset variables #4324

Merged
merged 2 commits into from Jan 17, 2019

Conversation

Projects
None yet
2 participants
@SSE4
Copy link
Contributor

commented Jan 16, 2019

closes #4323

Changelog: Fix: ensure tools.environment_append doesn't raise trying to unset variables
Docs: conan-io/docs#1023

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.

- ensure tools.environment_append doesn't raise trying to unset varia…
…bles

Signed-off-by: SSE4 <tomskside@gmail.com>

@ghost ghost assigned SSE4 Jan 16, 2019

@ghost ghost added the stage: review label Jan 16, 2019

Show resolved Hide resolved conans/client/tools/env.py Outdated
@lasote
Copy link
Contributor

left a comment

Change the pop

@lasote lasote added this to the 1.12 milestone Jan 17, 2019

@lasote

This comment has been minimized.

Copy link
Contributor

commented Jan 17, 2019

Missing docs PR

@SSE4

This comment has been minimized.

Copy link
Contributor Author

commented Jan 17, 2019

docs added

@lasote lasote merged commit 0e3d03b into conan-io:develop Jan 17, 2019

2 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
license/cla Contributor License Agreement is signed.
Details

@ghost ghost removed the stage: review label Jan 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.