Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4331 Bump pyOpenSSL version for OSX #4333

Merged
merged 1 commit into from Jan 18, 2019

Conversation

Projects
None yet
4 participants
@uilianries
Copy link
Member

commented Jan 17, 2019

closes #4331
Changelog: Fix: Bumped requirement of pyOpenSSL on OSX to >=16.0.0, <19.0.0
Docs: Omit

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.

#4331 Bump pyOpenSSL version for OSX
Signed-off-by: Uilian Ries <uilianries@gmail.com>

@ghost ghost assigned uilianries Jan 17, 2019

@ghost ghost added the stage: review label Jan 17, 2019

@lasote lasote added this to the 1.12 milestone Jan 17, 2019

@SSE4

This comment has been minimized.

Copy link
Contributor

commented Jan 18, 2019

@uilianries I am not fully sure how do requirements.txt work in such case, but won't we constantly run into this issue if CPT and conan have different requirements for requests?
https://github.com/conan-io/conan-package-tools/blob/develop/cpt/requirements.txt#L3
https://github.com/conan-io/conan/blob/develop/conans/requirements.txt#L2
as it will probably conflict from time to time, may be it makes sense to align them?

@lasote lasote removed this from the 1.12 milestone Jan 18, 2019

@lasote

This comment has been minimized.

Copy link
Contributor

commented Jan 18, 2019

I agree with @SSE4, probably the best we can do is to open the PR in CPT to align the cryptography and pyopenssl versions. WDYT? @uilianries?

cryptography>=1.3.4, <2.4.0
pyOpenSSL>=16.0.0, <18.0.0
@memsharded

This comment has been minimized.

Copy link
Contributor

commented Jan 18, 2019

I can't recall, but I think there was something: Is there some reason why conan shouldn't be using the latest pyOpenSSL? (18.0.0 https://pypi.org/project/pyOpenSSL/#history)

@lasote

This comment has been minimized.

Copy link
Contributor

commented Jan 18, 2019

That is not the point. It would solve the reported issue only circumstantially. The root cause is that the requirements from cpt and conan are not aligned. Bump pyopenssl would make it match today, but only tomorrow.
Said that we can perfectly upgrade pyopenssl afaik, if you can use this chance (pr) to do it, perfect, but the fix as I see it is not here.

@uilianries

This comment has been minimized.

Copy link
Member Author

commented Jan 18, 2019

I agree with both.

We need to align both versions to avoid new problem in the future. But also I think is a good idea keep pyOpenSSL updated for security.

Why not change CPT to pyOpenSSL>=16.0.0, <19.0.0 too?

@lasote

This comment has been minimized.

Copy link
Contributor

commented Jan 18, 2019

Ok, let's do that.

@uilianries

This comment has been minimized.

Copy link
Member Author

commented Jan 18, 2019

I'm gonna patch soon

@lasote lasote added this to the 1.12 milestone Jan 18, 2019

@lasote lasote merged commit bfc066f into conan-io:develop Jan 18, 2019

2 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
license/cla Contributor License Agreement is signed.
Details

@ghost ghost removed the stage: review label Jan 18, 2019

@uilianries

This comment has been minimized.

Copy link
Member Author

commented Jan 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.