Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated OS versions for apple products. #4345

Merged
merged 2 commits into from Jan 24, 2019

Conversation

Projects
None yet
4 participants
@laundry-96
Copy link
Contributor

commented Jan 19, 2019

Specifically updated the versions for iOS, watchOS, and tvOS.

Changelog: Feature: Updated OS versions for apple products
Docs: omit

The issue this refers to is #4344

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.

Updated OS versions for apple products.
Specifically updated the versions for iOS, watchOS, and tvOS.
@CLAassistant

This comment has been minimized.

Copy link

commented Jan 19, 2019

CLA assistant check
All committers have signed the CLA.

watchOS:
version: ["4.0"]
version: ["4.0", "4.0.1", "4.1", "4.2", "4.2.2", "4.2.3", "4.3", "4.3.1", "4.3.2", "5.0", "5.0.1", "5.1", "5.1.1", "5.1.2", "5.1.3"]

This comment has been minimized.

Copy link
@lasote

lasote Jan 21, 2019

Contributor

@SSE4 @laundry-96 any insight about the need of specifying the "patch" version (4.2.3)? for watchOS and tvOS? our criteria here should be the "compatibility".

This comment has been minimized.

Copy link
@SSE4

SSE4 Jan 21, 2019

Contributor

these version numbers are intended to be used for flags like -mios-version-min (or IOS_DEPLOYMENT_TARGET environment variable).
this works in general in conjunction with availability macro definitions, as documented at:
https://clang.llvm.org/docs/AttributeReference.html#availability
http://clang.llvm.org/docs/LanguageExtensions.html#objective-c-available
such version numbers define SDK version which introduced some functions.
as Apple documents, SDK versions are major + minor:
https://developer.apple.com/library/archive/documentation/DeveloperTools/Conceptual/cross_development/Configuring/configuring.html

An OS X SDK is named by major version, such as MacOSX10.6.sdk, but represents the latest minor version available for the major version.
The iOS SDKs are named by minor versions of iOS, such as iPhoneOS4.2.sdk.

Therefore, from my point of view, it doesn't make such sense to add minor versions into the conan default settings.

@laundry-96

This comment has been minimized.

Copy link
Contributor Author

commented Jan 23, 2019

Removed the patch versions from init.py

@lasote lasote added this to the 1.12 milestone Jan 24, 2019

@lasote lasote merged commit 4ad0ec6 into conan-io:develop Jan 24, 2019

2 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.